From: Mengdong Lin Date: Thu, 28 Mar 2013 09:20:22 +0000 (-0400) Subject: ALSA: hda - bug fix on return value when getting HDMI ELD info X-Git-Tag: v5.15~20363^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2ef5692efad330b67a234e2c49edad38538751e7;p=platform%2Fkernel%2Flinux-starfive.git ALSA: hda - bug fix on return value when getting HDMI ELD info In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0. Otherwise it will be returned uninitialized as non-zero after ELD info is got successfully. Thus hdmi_present_sense() will always assume ELD info is invalid by mistake, and /proc file system cannot show the proper ELD info. Signed-off-by: Mengdong Lin Cc: stable@vger.kernel.org Acked-by: David Henningsson Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c index 7dd8463..d0d7ac1 100644 --- a/sound/pci/hda/hda_eld.c +++ b/sound/pci/hda/hda_eld.c @@ -320,7 +320,7 @@ int snd_hdmi_get_eld(struct hda_codec *codec, hda_nid_t nid, unsigned char *buf, int *eld_size) { int i; - int ret; + int ret = 0; int size; /*