From: Seunghun Lee Date: Fri, 15 Feb 2019 08:56:09 +0000 (+0900) Subject: e_comp_wl: Remove return code by validation of below_obj. X-Git-Tag: submit/tizen/20190219.095209~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2ee3eab22d88cbf80dd570f79c5a3cedd108b1ee;p=platform%2Fupstream%2Fenlightenment.git e_comp_wl: Remove return code by validation of below_obj. _e_comp_wl_subsurface_check_below_bg_rectangle() implementation should handle the case that below_obj is exist in case of alpha client. Change-Id: Idc455eb44f3915525275a59946fb6594442bfc4e --- diff --git a/src/bin/e_comp_wl.c b/src/bin/e_comp_wl.c index 9604c78d10..95c33bf964 100644 --- a/src/bin/e_comp_wl.c +++ b/src/bin/e_comp_wl.c @@ -3583,13 +3583,11 @@ _e_comp_wl_subsurface_check_below_bg_rectangle(E_Client *ec) short layer; if (!ec || e_object_is_del(E_OBJECT(ec)) || !ec->comp_data) return; - if (ec->comp_data->sub.below_obj) return; if (ec->comp_data->sub.data) { E_Client *topmost = e_comp_wl_topmost_parent_get(ec); if (!topmost || e_object_is_del(E_OBJECT(topmost)) || !topmost->comp_data) return; if (topmost->comp_data->sub.data) return; - if (topmost->comp_data->sub.below_obj) return; _e_comp_wl_subsurface_check_below_bg_rectangle(topmost); return; } @@ -3598,15 +3596,17 @@ _e_comp_wl_subsurface_check_below_bg_rectangle(E_Client *ec) { if (ec->comp_data->sub.below_obj) { + ELOGF("COMP", " |bg_rectangle(%p) delete", ec, ec->comp_data->sub.below_obj); evas_object_del(ec->comp_data->sub.below_obj); ec->comp_data->sub.below_obj = NULL; } return; } - if (ec->comp_data->sub.below_list || - ec->comp_data->sub.below_list_pending || - e_comp_wl_video_subsurface_has(ec)) + if ((!ec->comp_data->sub.below_obj) && + (ec->comp_data->sub.below_list || + ec->comp_data->sub.below_list_pending || + e_comp_wl_video_subsurface_has(ec))) { /* create a bg rectangle if topmost window is 24 depth window */ ec->comp_data->sub.below_obj = evas_object_rectangle_add(e_comp->evas);