From: Mengkejiergeli Ba <mengkejiergeli.ba@intel.com>
Date: Tue, 12 Oct 2021 09:44:27 +0000 (+0800)
Subject: va: Fix error handling for base transform
X-Git-Tag: 1.19.3~236
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2eaba0cefa6e8d39bccdba3e83b7585a8866e05c;p=platform%2Fupstream%2Fgstreamer.git

va: Fix error handling for base transform

Need to check the returned value of gst_buffer_pool_set_active() when
setting the active status of buffer pool.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1131>
---

diff --git a/subprojects/gst-plugins-bad/sys/va/gstvabasetransform.c b/subprojects/gst-plugins-bad/sys/va/gstvabasetransform.c
index 13bad4eb..eff18cb 100644
--- a/subprojects/gst-plugins-bad/sys/va/gstvabasetransform.c
+++ b/subprojects/gst-plugins-bad/sys/va/gstvabasetransform.c
@@ -729,7 +729,11 @@ _get_sinkpad_pool (GstVaBaseTransform * self)
 
   gst_object_unref (allocator);
 
-  gst_buffer_pool_set_active (self->priv->sinkpad_pool, TRUE);
+  if (!gst_buffer_pool_set_active (self->priv->sinkpad_pool, TRUE)) {
+    GST_WARNING_OBJECT (self, "failed to active the sinkpad pool %"
+        GST_PTR_FORMAT, self->priv->sinkpad_pool);
+    return NULL;
+  }
 
   return self->priv->sinkpad_pool;
 }