From: Gustavo A. R. Silva Date: Wed, 9 Aug 2017 16:09:33 +0000 (-0500) Subject: pinctrl: amd: fix error return code in amd_gpio_probe() X-Git-Tag: v4.14-rc1~142^2~41 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2e6424ab852a24cac6d918f3ee002e57febe02c3;p=platform%2Fkernel%2Flinux-rpi.git pinctrl: amd: fix error return code in amd_gpio_probe() platform_get_irq() returns an error code, but the pinctrl-amd driver ignores it and always returns -EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly. Print and propagate the return value of platform_get_irq on failure. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index e6779d4..38af1ec 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -760,8 +760,8 @@ static int amd_gpio_probe(struct platform_device *pdev) irq_base = platform_get_irq(pdev, 0); if (irq_base < 0) { - dev_err(&pdev->dev, "Failed to get gpio IRQ.\n"); - return -EINVAL; + dev_err(&pdev->dev, "Failed to get gpio IRQ: %d\n", irq_base); + return irq_base; } gpio_dev->pdev = pdev;