From: Jihoon Kim <jihoon48.kim@samsung.com>
Date: Wed, 12 Jan 2022 01:50:34 +0000 (+0900)
Subject: Fix double close issue
X-Git-Tag: submit/tizen/20220112.021207~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2e3d9421756738a659b3f68f31074ed72def323f;p=platform%2Fcore%2Fuifw%2Fcapi-ui-sticker.git

Fix double close issue

Handler 'db' is passed to a function at sticker-parser.c:884 by calling function 'sqlite3_close' after the handler is closed again at sticker-parser.c:861 by calling function 'sqlite3_close'.

Handler 'stmt' is passed to a function at sticker-parser.c:842 by calling function 'sqlite3_finalize' after the handler is closed again at sticker-parser.c:819 by calling function 'sqlite3_finalize'.

Change-Id: I969482a8713925dcf4539d70717f132d74cf987b
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
---

diff --git a/sticker-parser/sticker-parser.c b/sticker-parser/sticker-parser.c
index 321e141..20bd406 100644
--- a/sticker-parser/sticker-parser.c
+++ b/sticker-parser/sticker-parser.c
@@ -775,8 +775,6 @@ static void __delete_sticker_allowlist(const char *db_path, const char *app_id)
     ret = sqlite3_prepare_v2(db, "DELETE FROM sticker_whitelist_info WHERE provider_id = ?", -1, &stmt, NULL);
     if (ret != SQLITE_OK) {
         LOGE("failed to delete sticker allowlist : %s", sqlite3_errmsg(db));
-        sqlite3_finalize(stmt);
-        sqlite3_close(db);
         goto cleanup;
     }
 
@@ -816,8 +814,6 @@ static void __delete_sticker_info(const char *db_path, int record_id)
     ret = sqlite3_prepare_v2(db, "DELETE FROM sticker_info WHERE sticker_info_id = ?", -1, &stmt, NULL);
     if (ret != SQLITE_OK) {
         LOGE("failed to delete sticker information : %s", sqlite3_errmsg(db));
-        sqlite3_finalize(stmt);
-        sqlite3_close(db);
         goto cleanup;
     }
 
@@ -857,8 +853,6 @@ static void __delete_group_info(const char *db_path, const char *app_id)
     ret = sqlite3_prepare_v2(db, "DELETE FROM sticker_group_info WHERE app_id = ?", -1, &stmt, NULL);
     if (ret != SQLITE_OK) {
         LOGE("failed to delete group information : %s", sqlite3_errmsg(db));
-        sqlite3_finalize(stmt);
-        sqlite3_close(db);
         goto cleanup;
     }
 
@@ -1109,4 +1103,4 @@ int PKGMGR_CATEGORY_PARSER_PLUGIN_UPGRADE(const char *pkgid, const char *appid,
     PKGMGR_CATEGORY_PARSER_PLUGIN_INSTALL(pkgid, appid, list);
 
     return 0;
-}
\ No newline at end of file
+}