From: Roel Kluin Date: Wed, 9 Dec 2009 20:31:36 +0000 (-0800) Subject: serial: imx: bit &/| confusion X-Git-Tag: v2.6.33-rc5~4^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2e2eb509aa7a333fe9931cf306fc7dbc3473f25b;p=profile%2Fivi%2Fkernel-x86-ivi.git serial: imx: bit &/| confusion Since UCR1_UARTEN is defined 1, the port was always treated as enabled. Signed-off-by: Roel Kluin Cc: Alan Cox Acked-by: Oskar Schirmer Cc: Sascha Hauer Cc: Fabian Godehardt Cc: Daniel Glöckner Cc: Russell King Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c index 18130f1..60d665a 100644 --- a/drivers/serial/imx.c +++ b/drivers/serial/imx.c @@ -1088,7 +1088,7 @@ imx_console_get_options(struct imx_port *sport, int *baud, int *parity, int *bits) { - if ( readl(sport->port.membase + UCR1) | UCR1_UARTEN ) { + if (readl(sport->port.membase + UCR1) & UCR1_UARTEN) { /* ok, the port was enabled */ unsigned int ucr2, ubir,ubmr, uartclk; unsigned int baud_raw;