From: Sagi Grimberg Date: Thu, 15 Aug 2013 14:04:42 +0000 (+0300) Subject: IB/iser: Fix redundant pointer check in dealloc flow X-Git-Tag: v5.15~19431^2^4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2e02d653febff23de614dc8978c64fbaa2767d85;p=platform%2Fkernel%2Flinux-starfive.git IB/iser: Fix redundant pointer check in dealloc flow This bug was discovered by Smatch static checker run by Dan Carpenter. If in free_rx_descriptors(), rx_descs are not NULL then the iser device is definately not NULL, so no need to check it before dereferencing it. Signed-off-by: Sagi Grimberg Signed-off-by: Or Gerlitz Signed-off-by: Roland Dreier --- diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index bdc38f4..5f01da9 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++ b/drivers/infiniband/ulp/iser/iser_initiator.c @@ -310,7 +310,7 @@ void iser_free_rx_descriptors(struct iser_conn *ib_conn) if (!ib_conn->rx_descs) goto free_login_buf; - if (device && device->iser_free_rdma_reg_res) + if (device->iser_free_rdma_reg_res) device->iser_free_rdma_reg_res(ib_conn); rx_desc = ib_conn->rx_descs;