From: Christoph Hellwig <hch@lst.de>
Date: Wed, 18 Oct 2017 11:20:01 +0000 (+0200)
Subject: nvme: use kref_get_unless_zero in nvme_find_get_ns
X-Git-Tag: v4.19~2212^2~86^2~24
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2dd4122854f697afc777582d18548dded03ce5dd;p=platform%2Fkernel%2Flinux-rpi.git

nvme: use kref_get_unless_zero in nvme_find_get_ns

For kref_get_unless_zero to protect against lookup vs free races we need
to use it in all places where we aren't guaranteed to already hold a
reference.  There is no such guarantee in nvme_find_get_ns, so switch to
kref_get_unless_zero in this function.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
---

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 7fae42d..1d931de 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2290,7 +2290,8 @@ static struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid)
 	mutex_lock(&ctrl->namespaces_mutex);
 	list_for_each_entry(ns, &ctrl->namespaces, list) {
 		if (ns->ns_id == nsid) {
-			kref_get(&ns->kref);
+			if (!kref_get_unless_zero(&ns->kref))
+				continue;
 			ret = ns;
 			break;
 		}