From: Oded Gabbay Date: Mon, 18 Jan 2021 19:39:46 +0000 (+0200) Subject: habanalabs: disable FW events on device removal X-Git-Tag: accepted/tizen/unified/20230118.172025~8019^2~1^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2dc4a6d79168e7e426e8ddf8e7219c9ffd13b2b1;p=platform%2Fkernel%2Flinux-rpi.git habanalabs: disable FW events on device removal When device is removed, we need to make sure the F/W won't send us any more events because during the remove process we disable the interrupts. Signed-off-by: Oded Gabbay --- diff --git a/drivers/misc/habanalabs/common/device.c b/drivers/misc/habanalabs/common/device.c index 1ea57d8..69d04ec 100644 --- a/drivers/misc/habanalabs/common/device.c +++ b/drivers/misc/habanalabs/common/device.c @@ -1487,6 +1487,15 @@ void hl_device_fini(struct hl_device *hdev) } } + /* Disable PCI access from device F/W so it won't send us additional + * interrupts. We disable MSI/MSI-X at the halt_engines function and we + * can't have the F/W sending us interrupts after that. We need to + * disable the access here because if the device is marked disable, the + * message won't be send. Also, in case of heartbeat, the device CPU is + * marked as disable so this message won't be sent + */ + hl_fw_send_pci_access_msg(hdev, CPUCP_PACKET_DISABLE_PCI_ACCESS); + /* Mark device as disabled */ hdev->disabled = true;