From: Pavel Labath <pavel@labath.sk>
Date: Fri, 28 Dec 2018 13:34:50 +0000 (+0000)
Subject: Fix signed-unsigned comparisons in MinidumpParserTest
X-Git-Tag: llvmorg-8.0.0-rc1~1208
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2da15e4dc8f9c82a1098385251b7e8d2ad0c9cda;p=platform%2Fupstream%2Fllvm.git

Fix signed-unsigned comparisons in MinidumpParserTest

llvm-svn: 350122
---

diff --git a/lldb/unittests/Process/minidump/MinidumpParserTest.cpp b/lldb/unittests/Process/minidump/MinidumpParserTest.cpp
index 610d3df..92ea20f 100644
--- a/lldb/unittests/Process/minidump/MinidumpParserTest.cpp
+++ b/lldb/unittests/Process/minidump/MinidumpParserTest.cpp
@@ -636,8 +636,8 @@ TEST_F(MinidumpParserTest, MinidumpDuplicateModuleMinAddress) {
   // one time, we pick the one with the lowest base_of_image.
   std::vector<const MinidumpModule *> filtered_modules =
       parser->GetFilteredModuleList();
-  EXPECT_EQ(1, filtered_modules.size());
-  EXPECT_EQ(0x0000000000001000, filtered_modules[0]->base_of_image);
+  EXPECT_EQ(1u, filtered_modules.size());
+  EXPECT_EQ(0x0000000000001000u, filtered_modules[0]->base_of_image);
 }
 
 TEST_F(MinidumpParserTest, MinidumpModuleOrder) {
@@ -652,12 +652,12 @@ TEST_F(MinidumpParserTest, MinidumpModuleOrder) {
   std::vector<const MinidumpModule *> filtered_modules =
       parser->GetFilteredModuleList();
   llvm::Optional<std::string> name;
-  EXPECT_EQ(2, filtered_modules.size());
-  EXPECT_EQ(0x0000000000002000, filtered_modules[0]->base_of_image);
+  EXPECT_EQ(2u, filtered_modules.size());
+  EXPECT_EQ(0x0000000000002000u, filtered_modules[0]->base_of_image);
   name = parser->GetMinidumpString(filtered_modules[0]->module_name_rva);
   ASSERT_TRUE((bool)name);
   EXPECT_EQ(std::string("/tmp/a"), *name);
-  EXPECT_EQ(0x0000000000001000, filtered_modules[1]->base_of_image);
+  EXPECT_EQ(0x0000000000001000u, filtered_modules[1]->base_of_image);
   name = parser->GetMinidumpString(filtered_modules[1]->module_name_rva);
   ASSERT_TRUE((bool)name);
   EXPECT_EQ(std::string("/tmp/b"), *name);