From: Krzysztof Kozlowski Date: Tue, 1 Sep 2020 15:27:08 +0000 (+0200) Subject: spi: spi-mux: Simplify with dev_err_probe() X-Git-Tag: v5.15~2347^2~105 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d9bdf645584d15ed1d4aae6204cb6ea8b673d48;p=platform%2Fkernel%2Flinux-starfive.git spi: spi-mux: Simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20200901152713.18629-6-krzk@kernel.org Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-mux.c b/drivers/spi/spi-mux.c index cc9ef37..37dfc6e 100644 --- a/drivers/spi/spi-mux.c +++ b/drivers/spi/spi-mux.c @@ -139,9 +139,8 @@ static int spi_mux_probe(struct spi_device *spi) priv->mux = devm_mux_control_get(&spi->dev, NULL); if (IS_ERR(priv->mux)) { - ret = PTR_ERR(priv->mux); - if (ret != -EPROBE_DEFER) - dev_err(&spi->dev, "failed to get control-mux\n"); + ret = dev_err_probe(&spi->dev, PTR_ERR(priv->mux), + "failed to get control-mux\n"); goto err_put_ctlr; }