From: Tommi Myöhänen <ext-tommi.1.myohanen@nokia.com>
Date: Mon, 27 Jul 2009 11:03:59 +0000 (+0300)
Subject: camerabin: photo iface setter functions return TRUE when used in NULL state
X-Git-Tag: 1.19.3~507^2~18343
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d9bdb933d40c0f32dd353b792ac0e70374e5192;p=platform%2Fupstream%2Fgstreamer.git

camerabin: photo iface setter functions return TRUE when used in NULL state

We cache the values and apply then when possible.
---

diff --git a/gst/camerabin/gstcamerabinphotography.c b/gst/camerabin/gstcamerabinphotography.c
index cb17abc..c568914 100644
--- a/gst/camerabin/gstcamerabinphotography.c
+++ b/gst/camerabin/gstcamerabinphotography.c
@@ -42,7 +42,7 @@ gst_camerabin_set_ev_compensation (GstPhotography * photo,
     gfloat ev_compensation)
 {
   GstCameraBin *camera;
-  gboolean ret = FALSE;
+  gboolean ret = TRUE;
 
   g_return_val_if_fail (photo != NULL, FALSE);
 
@@ -82,7 +82,7 @@ static gboolean
 gst_camerabin_set_iso_speed (GstPhotography * photo, guint iso_speed)
 {
   GstCameraBin *camera;
-  gboolean ret = FALSE;
+  gboolean ret = TRUE;
 
   g_return_val_if_fail (photo != NULL, FALSE);
 
@@ -120,7 +120,7 @@ gst_camerabin_set_white_balance_mode (GstPhotography * photo,
     GstWhiteBalanceMode white_balance_mode)
 {
   GstCameraBin *camera;
-  gboolean ret = FALSE;
+  gboolean ret = TRUE;
 
   g_return_val_if_fail (photo != NULL, FALSE);
 
@@ -161,7 +161,7 @@ gst_camerabin_set_colour_tone_mode (GstPhotography * photo,
     GstColourToneMode colour_tone_mode)
 {
   GstCameraBin *camera;
-  gboolean ret = FALSE;
+  gboolean ret = TRUE;
 
   g_return_val_if_fail (photo != NULL, FALSE);
 
@@ -201,7 +201,7 @@ static gboolean
 gst_camerabin_set_flash_mode (GstPhotography * photo, GstFlashMode flash_mode)
 {
   GstCameraBin *camera;
-  gboolean ret = FALSE;
+  gboolean ret = TRUE;
 
   g_return_val_if_fail (photo != NULL, FALSE);
 
@@ -269,7 +269,7 @@ static gboolean
 gst_camerabin_set_scene_mode (GstPhotography * photo, GstSceneMode scene_mode)
 {
   GstCameraBin *camera;
-  gboolean ret = FALSE;
+  gboolean ret = TRUE;
 
   g_return_val_if_fail (photo != NULL, FALSE);
 
@@ -345,7 +345,7 @@ static gboolean
 gst_camerabin_set_config (GstPhotography * photo, GstPhotoSettings * config)
 {
   GstCameraBin *camera;
-  gboolean ret = FALSE;
+  gboolean ret = TRUE;
   g_return_val_if_fail (photo != NULL, FALSE);
   camera = GST_CAMERABIN (photo);