From: Dave Stevenson Date: Thu, 8 Oct 2020 14:35:14 +0000 (+0100) Subject: staging: bcm2835-camera: Replace deprecated V4L2_PIX_FMT_BGR32 X-Git-Tag: accepted/tizen/unified/20240422.153132~733 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d7f81e4f77ea08ab1093df7b85a0e465e03fcd0;p=platform%2Fkernel%2Flinux-rpi.git staging: bcm2835-camera: Replace deprecated V4L2_PIX_FMT_BGR32 V4L2_PIX_FMT_BGR32 is deprecated as it is ambiguous over where the alpha byte is. Cheese/GStreamer appear to get it wrong for one, and qv4l2 gets red and blue swapped. Swap to the newer V4L2_PIX_FMT_BGRX32 format. https://www.raspberrypi.org/forums/viewtopic.php?f=38&t=267736&p=1738912 Signed-off-by: Dave Stevenson --- diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index 25e2ac4..076f9c4 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -176,7 +176,7 @@ static struct mmal_fmt formats[] = { .ybbp = 1, .remove_padding = true, }, { - .fourcc = V4L2_PIX_FMT_BGR32, + .fourcc = V4L2_PIX_FMT_BGRX32, .mmal = MMAL_ENCODING_BGRA, .depth = 32, .mmal_component = COMP_CAMERA,