From: Alexandre Belloni Date: Mon, 24 Sep 2018 15:05:08 +0000 (+0200) Subject: rtc: rs5c348: remove forward declaration X-Git-Tag: v5.4-rc1~2341^2~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d7be4ed7addcaae8eba6ae8cdee83e2f7d39059;p=platform%2Fkernel%2Flinux-rpi.git rtc: rs5c348: remove forward declaration The name passed to devm_rtc_device_register is now unused. anyway, switch to devm_rtc_allocate_device to avoid forward declaring rs5c348_driver. Signed-off-by: Alexandre Belloni --- diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c index aeb14fc..7b9c7dc 100644 --- a/drivers/rtc/rtc-rs5c348.c +++ b/drivers/rtc/rtc-rs5c348.c @@ -143,8 +143,6 @@ static const struct rtc_class_ops rs5c348_rtc_ops = { .set_time = rs5c348_rtc_set_time, }; -static struct spi_driver rs5c348_driver; - static int rs5c348_probe(struct spi_device *spi) { int ret; @@ -195,15 +193,15 @@ static int rs5c348_probe(struct spi_device *spi) if (ret & RS5C348_BIT_24H) pdata->rtc_24h = 1; - rtc = devm_rtc_device_register(&spi->dev, rs5c348_driver.driver.name, - &rs5c348_rtc_ops, THIS_MODULE); - + rtc = devm_rtc_allocate_device(&spi->dev); if (IS_ERR(rtc)) return PTR_ERR(rtc); pdata->rtc = rtc; - return 0; + rtc->ops = &rs5c348_rtc_ops; + + return rtc_register_device(rtc); } static struct spi_driver rs5c348_driver = {