From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Mon, 27 May 2013 11:11:27 +0000 (+0900)
Subject: Smack: Fix possible NULL pointer dereference at smk_netlbl_mls()
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d641ee90fc34922de2200d14f501a5951931b11;p=platform%2Fkernel%2Flinux-arm64.git

Smack: Fix possible NULL pointer dereference at smk_netlbl_mls()

netlbl_secattr_catmap_alloc(GFP_ATOMIC) can return NULL.

Change-Id: Id67f7f66a61a05e7e45b66a50b5d0869ef7e5117
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---

diff --git a/security/smack/smack_access.c b/security/smack/smack_access.c
index 53f2327a592..6a0377f3862 100644
--- a/security/smack/smack_access.c
+++ b/security/smack/smack_access.c
@@ -403,6 +403,8 @@ int smk_netlbl_mls(int level, char *catset, struct netlbl_lsm_secattr *sap,
 	sap->flags |= NETLBL_SECATTR_MLS_CAT;
 	sap->attr.mls.lvl = level;
 	sap->attr.mls.cat = netlbl_secattr_catmap_alloc(GFP_ATOMIC);
+	if (!sap->attr.mls.cat)
+		return -ENOMEM;
 	sap->attr.mls.cat->startbit = 0;
 
 	for (cat = 1, cp = catset, byte = 0; byte < len; cp++, byte++)