From: Danny Baumann <dannybaumann@web.de>
Date: Tue, 19 Mar 2013 16:22:51 +0000 (+0000)
Subject: ACPI / video: Make logic a little easier to understand.
X-Git-Tag: v3.12-rc1~830^2~9^2~10
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d4128a25206685aaccaf14220c8436b11c6dc01;p=kernel%2Fkernel-generic.git

ACPI / video: Make logic a little easier to understand.

Make code paths a little easier to follow, and don't needlessly continue
list iteration.

Signed-off-by: Danny Baumann <dannybaumann@web.de>
Reviewed-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 387b370..8522d14 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -745,16 +745,17 @@ acpi_video_init_brightness(struct acpi_video_device *device)
 		 */
 		if (use_bios_initial_backlight) {
 			for (i = 2; i < br->count; i++)
-				if (level_old == br->levels[i])
+				if (level_old == br->levels[i]) {
 					level = level_old;
+					break;
+				}
 		}
-		goto set_level;
+	} else {
+		if (br->flags._BCL_reversed)
+			level_old = (br->count - 1) - level_old;
+		level = br->levels[level_old];
 	}
 
-	if (br->flags._BCL_reversed)
-		level_old = (br->count - 1) - level_old;
-	level = br->levels[level_old];
-
 set_level:
 	result = acpi_video_device_lcd_set_level(device, level);
 	if (result)