From: Layomi Akinrinade <laakinri@microsoft.com>
Date: Fri, 22 May 2020 21:49:34 +0000 (-0400)
Subject: Improve obsoletion message for IgnoreNullValues (#36886)
X-Git-Tag: submit/tizen/20210909.063632~7806
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d343933de876291bc58403b0b0243a988731d15;p=platform%2Fupstream%2Fdotnet%2Fruntime.git

Improve obsoletion message for IgnoreNullValues (#36886)
---

diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
index 27dc1fe..05b2aec 100644
--- a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
+++ b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
@@ -199,7 +199,7 @@ namespace System.Text.Json
         /// Thrown if this property is set after serialization or deserialization has occurred.
         /// or <see cref="DefaultIgnoreCondition"/> has been set to a non-default value. These properties cannot be used together.
         /// </exception>
-        [Obsolete("Use DefaultIgnoreCondition instead.", error: false)]
+        [Obsolete("To ignore null values when serializing, set DefaultIgnoreCondition to JsonIgnoreCondition.WhenWritingDefault.", error: false)]
         [EditorBrowsable(EditorBrowsableState.Never)]
         public bool IgnoreNullValues
         {
@@ -211,7 +211,7 @@ namespace System.Text.Json
             {
                 VerifyMutable();
 
-                if (value == true && _defaultIgnoreCondition != JsonIgnoreCondition.Never)
+                if (value && _defaultIgnoreCondition != JsonIgnoreCondition.Never)
                 {
                     Debug.Assert(_defaultIgnoreCondition == JsonIgnoreCondition.WhenWritingDefault);
                     throw new InvalidOperationException(SR.DefaultIgnoreConditionAlreadySpecified);