From: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon, 8 Dec 2014 08:50:40 +0000 (+0800)
Subject: hwrng: don't init list element we're about to add to list.
X-Git-Tag: v4.14-rc1~5945^2~57
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d2ec0642a85966b6a299bbcd94707982327ace8;p=platform%2Fkernel%2Flinux-rpi.git

hwrng: don't init list element we're about to add to list.

Another interesting anti-pattern.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index e384ee3..6ec4225 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -485,7 +485,6 @@ int hwrng_register(struct hwrng *rng)
 			goto out_unlock;
 		}
 	}
-	INIT_LIST_HEAD(&rng->list);
 	list_add_tail(&rng->list, &rng_list);
 
 	if (old_rng && !rng->init) {