From: Simon Glass Date: Tue, 12 Jun 2018 05:26:40 +0000 (-0600) Subject: efi: Add a comment about duplicated ELF constants X-Git-Tag: v2018.07-rc2~50^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d2b5b2d007769ba48fd31223997df1d6b662c78;p=platform%2Fkernel%2Fu-boot.git efi: Add a comment about duplicated ELF constants These constants are defined in arch-specific code but redefined here. Add a TODO to clean this up. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt Signed-off-by: Alexander Graf --- diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c index 65f2bcf..4874eb6 100644 --- a/lib/efi_loader/efi_runtime.c +++ b/lib/efi_loader/efi_runtime.c @@ -28,6 +28,10 @@ static efi_status_t __efi_runtime EFIAPI efi_unimplemented(void); static efi_status_t __efi_runtime EFIAPI efi_device_error(void); static efi_status_t __efi_runtime EFIAPI efi_invalid_parameter(void); +/* + * TODO(sjg@chromium.org): These defines and structs should come from the elf + * header for each arch (or a generic header) rather than being repeated here. + */ #if defined(CONFIG_ARM64) #define R_RELATIVE 1027 #define R_MASK 0xffffffffULL