From: David Kershner <david.kershner@unisys.com>
Date: Mon, 21 Nov 2016 17:15:46 +0000 (-0500)
Subject: staging: unisys: visorbus: controlvm_respond add error handling
X-Git-Tag: v4.14-rc1~1919^2~118
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d26aeb77357678e38c931c760d57bda084112ea;p=platform%2Fkernel%2Flinux-rpi.git

staging: unisys: visorbus: controlvm_respond add error handling

The function visorchanel_signalinsert now returns an error, propagate
the error up the stack to be handled.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 331f6b1..0c454f6 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -548,19 +548,17 @@ out_respond:
 	return res;
 }
 
-static void
+static int
 controlvm_respond(struct controlvm_message_header *msg_hdr, int response)
 {
 	struct controlvm_message outmsg;
 
 	controlvm_init_response(&outmsg, msg_hdr, response);
 	if (outmsg.hdr.flags.test_message == 1)
-		return;
+		return -EINVAL;
 
-	if (visorchannel_signalinsert(controlvm_channel,
-				      CONTROLVM_QUEUE_REQUEST, &outmsg)) {
-		return;
-	}
+	return visorchannel_signalinsert(controlvm_channel,
+					 CONTROLVM_QUEUE_REQUEST, &outmsg);
 }
 
 static void controlvm_respond_physdev_changestate(