From: Pekka Pessi <Pekka.Pessi@nokia.com>
Date: Thu, 26 Aug 2010 14:26:42 +0000 (+0300)
Subject: ofono: do not strdup in get_ident()
X-Git-Tag: 2.0_alpha~2433
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d1ec537c78d2a9746c2733754922109916c087a;p=framework%2Fconnectivity%2Fconnman.git

ofono: do not strdup in get_ident()

Fix leak if network creation fails.
---

diff --git a/plugins/ofono.c b/plugins/ofono.c
index 72dad90..7d686a3 100644
--- a/plugins/ofono.c
+++ b/plugins/ofono.c
@@ -252,7 +252,7 @@ static char *get_ident(const char *path)
 	if (pos == NULL)
 		return NULL;
 
-	return g_strdup(pos + 1);
+	return pos + 1;
 }
 
 static void create_service(struct connman_network *network)
@@ -267,8 +267,6 @@ static void create_service(struct connman_network *network)
 	group = get_ident(path);
 
 	connman_network_set_group(network, group);
-
-	g_free(group);
 }
 
 static void set_network_name_reply(DBusPendingCall *call, void *user_data)
@@ -667,8 +665,6 @@ static void add_network(struct connman_device *device, const char *path)
 	if (network == NULL)
 		return;
 
-	g_free(ident);
-
 	connman_network_set_string(network, "Path", path);
 	connman_network_set_available(network, TRUE);
 	connman_network_set_index(network, -1);