From: Jacek Anaszewski Date: Mon, 19 Mar 2018 19:23:18 +0000 (+0100) Subject: Revert "led: core: Fix brightness setting when setting delay_off=0" X-Git-Tag: v4.9.90~171 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2d07d7d7032c340564d84cedfba60a4d53355e95;p=platform%2Fkernel%2Flinux-amlogic.git Revert "led: core: Fix brightness setting when setting delay_off=0" This reverts commit 86b9fa2190907f4f550d9d6bf490c5f89ca33836 which was commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c upstream. The commit being reverted has two flaws: - it introduces a regression, fixed in the upstream commit 7b6af2c53192f1766892ef40c8f48a413509ed72. - it has truncated commit message Reported-by: Sasha Levin Reported-by: Matthias Schiffer Signed-off-by: Jacek Anaszewski Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index d70d4a5273b8..3bce44893021 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -186,7 +186,7 @@ void led_blink_set(struct led_classdev *led_cdev, unsigned long *delay_on, unsigned long *delay_off) { - led_stop_software_blink(led_cdev); + del_timer_sync(&led_cdev->blink_timer); led_cdev->flags &= ~LED_BLINK_ONESHOT; led_cdev->flags &= ~LED_BLINK_ONESHOT_STOP;