From: Raphael Kubo da Costa Date: Thu, 25 Sep 2014 16:04:22 +0000 (+0300) Subject: system_info: Fix coding style violations. X-Git-Tag: accepted/tizen/common/20141002.100326~1^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2cf25065df423a604821f7d51c4e9013a57cacf8;p=platform%2Fframework%2Fweb%2Ftizen-extensions-crosswalk.git system_info: Fix coding style violations. ./system_info/system_info_sim_ivi.cc:129: If an else has a brace on one side, it should have it on both [readability/braces] [5] ./system_info/system_info_locale.h:35: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_cellular_network.h:34: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_network.h:54: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_wifi_network.h:44: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_cpu.h:37: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_device_orientation.h:41: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_peripheral.h:34: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_battery.h:38: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_build.h:44: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] ./system_info/system_info_display.h:48: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] BUG=XWALK-2649 --- diff --git a/system_info/system_info_battery.h b/system_info/system_info_battery.h index 1936365..7ef2bdb 100644 --- a/system_info/system_info_battery.h +++ b/system_info/system_info_battery.h @@ -35,7 +35,7 @@ class SysInfoBattery : public SysInfoObject { static const std::string name_; private: - explicit SysInfoBattery(); + SysInfoBattery(); bool Update(picojson::value& error); void SetData(picojson::value& data); diff --git a/system_info/system_info_build.h b/system_info/system_info_build.h index 681fddf..102467c 100644 --- a/system_info/system_info_build.h +++ b/system_info/system_info_build.h @@ -41,7 +41,7 @@ class SysInfoBuild : public SysInfoObject { static const std::string name_; private: - explicit SysInfoBuild() + SysInfoBuild() : timeout_cb_id_(0) {} bool UpdateHardware(); diff --git a/system_info/system_info_cellular_network.h b/system_info/system_info_cellular_network.h index 93896dd..150ccdb 100644 --- a/system_info/system_info_cellular_network.h +++ b/system_info/system_info_cellular_network.h @@ -31,7 +31,7 @@ class SysInfoCellularNetwork : public SysInfoObject { static const std::string name_; private: - explicit SysInfoCellularNetwork() {} + SysInfoCellularNetwork() {} #if defined(TIZEN) void SendUpdate(); diff --git a/system_info/system_info_cpu.h b/system_info/system_info_cpu.h index 7d576f2..e552b4c 100644 --- a/system_info/system_info_cpu.h +++ b/system_info/system_info_cpu.h @@ -34,7 +34,7 @@ class SysInfoCpu : public SysInfoObject { static const std::string name_; private: - explicit SysInfoCpu() + SysInfoCpu() : load_(0.0), old_total_(0), old_used_(0), diff --git a/system_info/system_info_device_orientation.h b/system_info/system_info_device_orientation.h index 048ffcc..e1fea40 100644 --- a/system_info/system_info_device_orientation.h +++ b/system_info/system_info_device_orientation.h @@ -38,7 +38,7 @@ class SysInfoDeviceOrientation : public SysInfoObject { static const std::string name_; private: - explicit SysInfoDeviceOrientation() + SysInfoDeviceOrientation() : status_(PORTRAIT_PRIMARY), sensorHandle_(0) {} diff --git a/system_info/system_info_display.h b/system_info/system_info_display.h index 1cd3277..3cc9435 100644 --- a/system_info/system_info_display.h +++ b/system_info/system_info_display.h @@ -45,7 +45,7 @@ class SysInfoDisplay : public SysInfoObject { static const std::string name_; private: - explicit SysInfoDisplay(); + SysInfoDisplay(); static gboolean OnUpdateTimeout(gpointer user_data); bool UpdateSize(); diff --git a/system_info/system_info_locale.h b/system_info/system_info_locale.h index dc7893d..a6e5516 100644 --- a/system_info/system_info_locale.h +++ b/system_info/system_info_locale.h @@ -32,7 +32,7 @@ class SysInfoLocale : public SysInfoObject { static const std::string name_; private: - explicit SysInfoLocale(); + SysInfoLocale(); bool GetLanguage(); bool GetCountry(); diff --git a/system_info/system_info_network.h b/system_info/system_info_network.h index 90b2398..662caff 100644 --- a/system_info/system_info_network.h +++ b/system_info/system_info_network.h @@ -51,7 +51,7 @@ class SysInfoNetwork : public SysInfoObject { static const std::string name_; private: - explicit SysInfoNetwork(); + SysInfoNetwork(); void PlatformInitialize(); bool Update(picojson::value& error); diff --git a/system_info/system_info_peripheral.h b/system_info/system_info_peripheral.h index 8eea389..28ed147 100644 --- a/system_info/system_info_peripheral.h +++ b/system_info/system_info_peripheral.h @@ -31,7 +31,7 @@ class SysInfoPeripheral : public SysInfoObject { static const std::string name_; private: - explicit SysInfoPeripheral() {} + SysInfoPeripheral() {} #if defined(TIZEN) void SetWFD(int wfd); diff --git a/system_info/system_info_sim_ivi.cc b/system_info/system_info_sim_ivi.cc index 754b021..05d0650 100644 --- a/system_info/system_info_sim_ivi.cc +++ b/system_info/system_info_sim_ivi.cc @@ -126,9 +126,8 @@ void SysInfoSim::UpdateSimProperty(const gchar* key, GVariant* var_val) { state_ = SYSTEM_INFO_SIM_UNKNOWN; else if (g_strcmp0(lock, "corppuk") == 0) state_ = SYSTEM_INFO_SIM_UNKNOWN; - else { + else state_ = SYSTEM_INFO_SIM_INITIALIZING; - } } } diff --git a/system_info/system_info_wifi_network.h b/system_info/system_info_wifi_network.h index 5085d0e..c92bd8a 100644 --- a/system_info/system_info_wifi_network.h +++ b/system_info/system_info_wifi_network.h @@ -41,7 +41,7 @@ class SysInfoWifiNetwork : public SysInfoObject { static const std::string name_; private: - explicit SysInfoWifiNetwork(); + SysInfoWifiNetwork(); void PlatformInitialize(); bool Update(picojson::value& error);