From: Roel Kluin <roel.kluin@gmail.com>
Date: Fri, 20 Feb 2009 08:52:19 +0000 (-0800)
Subject: SMSC: timeout reaches -1
X-Git-Tag: v2.6.29-rc7~13^2~31
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2cf0dbed27af3f827a96db98c2535002902f6af0;p=profile%2Fivi%2Fkernel-x86-ivi.git

SMSC: timeout reaches -1

With a postfix decrement timeouts will reach -1 rather than 0, so
the error path does not appear.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
index 783c1a7..9a78dae 100644
--- a/drivers/net/smsc911x.c
+++ b/drivers/net/smsc911x.c
@@ -1624,7 +1624,7 @@ static int smsc911x_eeprom_send_cmd(struct smsc911x_data *pdata, u32 op)
 	do {
 		msleep(1);
 		e2cmd = smsc911x_reg_read(pdata, E2P_CMD);
-	} while ((e2cmd & E2P_CMD_EPC_BUSY_) && (timeout--));
+	} while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout));
 
 	if (!timeout) {
 		SMSC_TRACE(DRV, "TIMED OUT");