From: Chaitanya Kulkarni Date: Mon, 25 Jan 2021 23:32:38 +0000 (-0800) Subject: n64: use enums for reg X-Git-Tag: accepted/tizen/unified/20230118.172025~7732^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2ce503b35dcea29767c6d03b44e3c535809fdfcc;p=platform%2Fkernel%2Flinux-rpi.git n64: use enums for reg Macros tend to be not type-safe. Use enum for register definitions. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Lauri Kasanen Signed-off-by: Thomas Bogendoerfer --- diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c index b18f034..620f9e0 100644 --- a/drivers/block/n64cart.c +++ b/drivers/block/n64cart.c @@ -13,11 +13,13 @@ #include #include -#define PI_DRAM_REG 0 -#define PI_CART_REG 1 -#define PI_READ_REG 2 -#define PI_WRITE_REG 3 -#define PI_STATUS_REG 4 +enum { + PI_DRAM_REG = 0, + PI_CART_REG, + PI_READ_REG, + PI_WRITE_REG, + PI_STATUS_REG, +}; #define PI_STATUS_DMA_BUSY (1 << 0) #define PI_STATUS_IO_BUSY (1 << 1)