From: Christopher Michael Date: Thu, 2 May 2019 11:48:00 +0000 (+0200) Subject: ecore_test_ecore_file: Fix resource leak X-Git-Tag: accepted/tizen/unified/20190509.041000~51 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2cdfbec78f5766c44c439eb7e5f220272bab5b60;p=platform%2Fupstream%2Fefl.git ecore_test_ecore_file: Fix resource leak Summary: Coverity reports that we leak the store returned from ecore_file_realpath so add a call to free the returned storage when we are done with it Fixes CID1400825 @fix Depends on D8777 Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi Reviewed By: segfaultxavi Subscribers: segfaultxavi, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8778 --- diff --git a/src/tests/ecore/ecore_test_ecore_file.c b/src/tests/ecore/ecore_test_ecore_file.c index 2f1648f..8fff2eb 100644 --- a/src/tests/ecore/ecore_test_ecore_file.c +++ b/src/tests/ecore/ecore_test_ecore_file.c @@ -466,6 +466,7 @@ EFL_START_TEST(ecore_test_ecore_file_monitor) _writeToFile(file_name, random_text); ck_assert_str_eq(ecore_file_monitor_path_get(mon), realp); + free(realp); ret = ecore_file_mksubdirs(src_dir, sub_dir); fail_if(ret != 1); @@ -486,7 +487,6 @@ EFL_START_TEST(ecore_test_ecore_file_monitor) ret = ecore_file_shutdown(); fail_if(ret != 0); - } EFL_END_TEST