From: Neta Ostrovsky Date: Wed, 13 Jan 2021 13:02:14 +0000 (+0200) Subject: RDMA/cma: Fix error flow in default_roce_mode_store X-Git-Tag: v5.10.17~625 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2cd90971a2c960c2c7a0f4e14fec8bf9c1a2e49b;p=platform%2Fkernel%2Flinux-rpi.git RDMA/cma: Fix error flow in default_roce_mode_store [ Upstream commit 7c7b3e5d9aeed31d35c5dab0bf9c0fd4c8923206 ] In default_roce_mode_store(), we took a reference to cma_dev, but didn't return it with cma_dev_put in the error flow. Fixes: 1c15b4f2a42f ("RDMA/core: Modify enum ib_gid_type and enum rdma_network_type") Link: https://lore.kernel.org/r/20210113130214.562108-1-leon@kernel.org Signed-off-by: Neta Ostrovsky Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- diff --git a/drivers/infiniband/core/cma_configfs.c b/drivers/infiniband/core/cma_configfs.c index 7ec4af2..35d1ec1 100644 --- a/drivers/infiniband/core/cma_configfs.c +++ b/drivers/infiniband/core/cma_configfs.c @@ -131,8 +131,10 @@ static ssize_t default_roce_mode_store(struct config_item *item, return ret; gid_type = ib_cache_gid_parse_type_str(buf); - if (gid_type < 0) + if (gid_type < 0) { + cma_configfs_params_put(cma_dev); return -EINVAL; + } ret = cma_set_default_gid_type(cma_dev, group->port_num, gid_type);