From: Shuah Khan <shuah@kernel.org>
Date: Thu, 24 Jan 2019 21:46:42 +0000 (-0700)
Subject: usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path
X-Git-Tag: v5.15~6882^2~67
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2c904963b1dd2acd4bc785b6c72e10a6283c2081;p=platform%2Fkernel%2Flinux-starfive.git

usbip: Fix vhci_urb_enqueue() URB null transfer buffer error path

Fix vhci_urb_enqueue() to print debug msg and return error instead of
failing with BUG_ON.

Signed-off-by: Shuah Khan <shuah@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index 1e592ec..f46ee1f 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -702,8 +702,10 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flag
 	}
 	vdev = &vhci_hcd->vdev[portnum-1];
 
-	/* patch to usb_sg_init() is in 2.5.60 */
-	BUG_ON(!urb->transfer_buffer && urb->transfer_buffer_length);
+	if (!urb->transfer_buffer && urb->transfer_buffer_length) {
+		dev_dbg(dev, "Null URB transfer buffer\n");
+		return -EINVAL;
+	}
 
 	spin_lock_irqsave(&vhci->lock, flags);