From: Behdad Esfahbod <behdad@behdad.org>
Date: Sun, 2 Aug 2009 19:20:22 +0000 (-0400)
Subject: [HB] Add XXX marks
X-Git-Tag: submit/master/20120920.151126~7^2~1108
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2c80296aa5991ad67483889147f5c84fefe54af2;p=framework%2Fuifw%2Fharfbuzz.git

[HB] Add XXX marks
---

diff --git a/src/hb-ot-layout-private.h b/src/hb-ot-layout-private.h
index 48e9145..3fdd428 100644
--- a/src/hb-ot-layout-private.h
+++ b/src/hb-ot-layout-private.h
@@ -28,7 +28,9 @@
 #define HB_OT_LAYOUT_PRIVATE_H
 
 #include "hb-private.h"
+
 #include "hb-ot-layout.h"
+
 #include "hb-buffer-private.h"
 
 
diff --git a/src/hb-ot-layout.cc b/src/hb-ot-layout.cc
index d04d54d..7e0539a 100644
--- a/src/hb-ot-layout.cc
+++ b/src/hb-ot-layout.cc
@@ -28,10 +28,6 @@
 
 #define HB_OT_LAYOUT_CC
 
-/* XXX */
-#include "hb-buffer-private.h"
-
-#include "hb-ot-layout.h"
 #include "hb-ot-layout-private.h"
 
 #include "hb-ot-layout-open-private.h"
@@ -263,7 +259,7 @@ hb_ot_layout_set_glyph_class (hb_ot_layout_t             *layout,
 			      hb_codepoint_t              glyph,
 			      hb_ot_layout_glyph_class_t  klass)
 {
-  /* TODO optimize this, similar to old harfbuzz code for example */
+  /* TODO optimize this? similar to old harfbuzz code for example */
 
   hb_ot_layout_class_t gdef_klass;
   int len = layout->new_gdef.len;
@@ -271,6 +267,7 @@ hb_ot_layout_set_glyph_class (hb_ot_layout_t             *layout,
   if (HB_UNLIKELY (glyph > 65535))
     return;
 
+  /* XXX this is not threadsafe */
   if (glyph >= len) {
     int new_len;
     unsigned char *new_klasses;