From: Konstantin Gukov <gukkos@gmail.com>
Date: Tue, 6 Aug 2024 18:19:39 +0000 (+0200)
Subject: dotnet-trace: don't fail if the trace file has no method calls (#4827)
X-Git-Tag: accepted/tizen/unified/20241231.014852~39^2^2~104
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2c1994334add963416f2f4431152c58504fbc443;p=platform%2Fcore%2Fdotnet%2Fdiagnostics.git

dotnet-trace: don't fail if the trace file has no method calls (#4827)

Before:

```
> dotnet-trace report dotnet_tracing_20240802_082746.nettrace topN -n 10
[ERROR] System.OverflowException: Arithmetic operation resulted in an overflow.
   at Microsoft.Diagnostics.Tools.Trace.CommandLine.PrintReportHelper.TopNWriteToStdOut(List`1 nodesToReport, Boolean isInclusive, Boolean isVerbose) in /_/src/Tools/dotnet-trace/CommandLine/PrintReportHelper.cs:line 99
   at Microsoft.Diagnostics.Tools.Trace.ReportCommandHandler.TopNReport(CancellationToken ct, IConsole console, String traceFile, Int32 number, Boolean inclusive, Boolean verbose) in /_/src/Tools/dotnet-trace/CommandLine/Commands/ReportCommand.cs:line 93
```

After:

```
> /home/gukov/diagnostics/artifacts/bin/dotnet-trace/Debug/net6.0/dotnet-trace report dotnet_tracing_20240802_082746.nettrace topN -n 10 -v
[WARNING] No method calls found
```

(written to stderr)
---

diff --git a/src/Tools/dotnet-trace/CommandLine/PrintReportHelper.cs b/src/Tools/dotnet-trace/CommandLine/PrintReportHelper.cs
index d74f25043..ec60dd8f9 100644
--- a/src/Tools/dotnet-trace/CommandLine/PrintReportHelper.cs
+++ b/src/Tools/dotnet-trace/CommandLine/PrintReportHelper.cs
@@ -96,6 +96,12 @@ namespace Microsoft.Diagnostics.Tools.Trace.CommandLine
             }
 
             int n = nodesToReport.Count;
+            if (n == 0)
+            {
+                Console.Error.WriteLine("[WARNING] No method calls found");
+                return;
+            }
+
             int maxDigit = (int)Math.Log10(n) + 1;
             string extra = new(' ', maxDigit - 1);