From: Colin Ian King Date: Sat, 8 Feb 2020 16:46:01 +0000 (+0000) Subject: USB: serial: digi_acceleport: remove redundant assignment to pointer priv X-Git-Tag: v5.15~4246^2~5^2~12 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2c0bee081315b18064fe39661e679b2fe6b86476;p=platform%2Fkernel%2Flinux-starfive.git USB: serial: digi_acceleport: remove redundant assignment to pointer priv Pointer priv is being assigned with a value that is never read, it is assigned a new value later on in a for-loop. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King Signed-off-by: Johan Hovold --- diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c index 578ebdd86520..91055a191995 100644 --- a/drivers/usb/serial/digi_acceleport.c +++ b/drivers/usb/serial/digi_acceleport.c @@ -1472,7 +1472,7 @@ static int digi_read_oob_callback(struct urb *urb) struct usb_serial_port *port = urb->context; struct usb_serial *serial = port->serial; struct tty_struct *tty; - struct digi_port *priv = usb_get_serial_port_data(port); + struct digi_port *priv; unsigned char *buf = urb->transfer_buffer; int opcode, line, status, val; unsigned long flags;