From: Wei Yongjun Date: Tue, 7 May 2013 02:23:38 +0000 (+0000) Subject: bfin_mac: fix error return code in bfin_mac_probe() X-Git-Tag: upstream/snapshot3+hdmi~5132^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2c006994520f3a4bb1d47a6afe5c58ff856497ce;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git bfin_mac: fix error return code in bfin_mac_probe() Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c index ee70577..dada66b 100644 --- a/drivers/net/ethernet/adi/bfin_mac.c +++ b/drivers/net/ethernet/adi/bfin_mac.c @@ -1700,7 +1700,8 @@ static int bfin_mac_probe(struct platform_device *pdev) } bfin_mac_hwtstamp_init(ndev); - if (bfin_phc_init(ndev, &pdev->dev)) { + rc = bfin_phc_init(ndev, &pdev->dev); + if (rc) { dev_err(&pdev->dev, "Cannot register PHC device!\n"); goto out_err_phc; }