From: Greg Kroah-Hartman Date: Thu, 2 Feb 2023 15:16:33 +0000 (+0100) Subject: kernel/fail_function: fix memory leak with using debugfs_lookup() X-Git-Tag: v6.6.7~3434^2~48 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2bb3669f576559db273efe49e0e69f82450efbca;p=platform%2Fkernel%2Flinux-starfive.git kernel/fail_function: fix memory leak with using debugfs_lookup() When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Andrew Morton Reviewed-by: Yang Yingliang Link: https://lore.kernel.org/r/20230202151633.2310897-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/kernel/fail_function.c b/kernel/fail_function.c index a7ccd29..d971a01 100644 --- a/kernel/fail_function.c +++ b/kernel/fail_function.c @@ -163,10 +163,7 @@ static void fei_debugfs_add_attr(struct fei_attr *attr) static void fei_debugfs_remove_attr(struct fei_attr *attr) { - struct dentry *dir; - - dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir); - debugfs_remove_recursive(dir); + debugfs_lookup_and_remove(attr->kp.symbol_name, fei_debugfs_dir); } static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs)