From: Luis Chamberlain Date: Mon, 27 Sep 2021 22:01:08 +0000 (-0700) Subject: pcd: fix ordering of unregister_cdrom() X-Git-Tag: v6.1-rc5~2682^2~113 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2b6cabce3954be3341e0fe7b20a27902821fd3dd;p=platform%2Fkernel%2Flinux-starfive.git pcd: fix ordering of unregister_cdrom() We first register cdrom and then we add_disk() and so we we should likewise unregister the cdrom first and then del_gendisk(). Signed-off-by: Luis Chamberlain Signed-off-by: Jens Axboe --- diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c index a7fab38..82a654f 100644 --- a/drivers/block/paride/pcd.c +++ b/drivers/block/paride/pcd.c @@ -1021,9 +1021,9 @@ static void __exit pcd_exit(void) if (!cd->present) continue; + unregister_cdrom(&cd->info); del_gendisk(cd->disk); pi_release(cd->pi); - unregister_cdrom(&cd->info); blk_cleanup_disk(cd->disk); blk_mq_free_tag_set(&cd->tag_set);