From: kbalazs@webkit.org <kbalazs@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu, 5 Jul 2012 11:21:47 +0000 (+0000)
Subject: [Qt] WTR crashes if a URL is passed as a parameter
X-Git-Tag: build/2012-07-06.143308~72
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2b54c4bde413e346a56fc9e5faac43c7dcfe99af;p=profile%2Fivi%2Fwebkit-efl.git

[Qt] WTR crashes if a URL is passed as a parameter
https://bugs.webkit.org/show_bug.cgi?id=88093

Reviewed by Zoltan Herczeg.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedURLAPI):
Don't special case null string. It's handled
fine by WebURL and passing 0 is not suitable
to the API.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---

diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
index 772b81e..1fe2426 100644
--- a/Source/WebKit2/ChangeLog
+++ b/Source/WebKit2/ChangeLog
@@ -1,3 +1,16 @@
+2012-07-05  Balazs Kelemen  <kbalazs@webkit.org>
+
+        [Qt] WTR crashes if a URL is passed as a parameter
+        https://bugs.webkit.org/show_bug.cgi?id=88093
+
+        Reviewed by Zoltan Herczeg.
+
+        * Shared/API/c/WKSharedAPICast.h:
+        (WebKit::toCopiedURLAPI):
+        Don't special case null string. It's handled
+        fine by WebURL and passing 0 is not suitable
+        to the API.
+
 2012-07-05  Dongwoo Im  <dw.im@samsung.com>
 
         [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
diff --git a/Source/WebKit2/Shared/API/c/WKSharedAPICast.h b/Source/WebKit2/Shared/API/c/WKSharedAPICast.h
index fd1a896..2fc7763 100644
--- a/Source/WebKit2/Shared/API/c/WKSharedAPICast.h
+++ b/Source/WebKit2/Shared/API/c/WKSharedAPICast.h
@@ -159,8 +159,6 @@ inline ProxyingRefPtr<WebURL> toURLRef(StringImpl* string)
 
 inline WKURLRef toCopiedURLAPI(const String& string)
 {
-    if (!string)
-        return 0;
     RefPtr<WebURL> webURL = WebURL::create(string);
     return toAPI(webURL.release().leakRef());
 }