From: yoonki.park <yoonki.park@samsung.com>
Date: Fri, 5 Jul 2013 08:36:18 +0000 (+0900)
Subject: verify code according to prevent rules
X-Git-Tag: submit/tizen_2.2/20130705.083911^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2b31e31dd86596a722e6424447a051d51b710098;p=sdk%2Ftarget%2Fsdbd.git

verify code according to prevent rules

Change-Id: Ie84cf3a94766148940ad4910db15889a5f3473fd
Signed-off-by: yoonki.park <yoonki.park@samsung.com>
---

diff --git a/src/file_sync_service.c b/src/file_sync_service.c
index 7b0f474..85bb31c 100644
--- a/src/file_sync_service.c
+++ b/src/file_sync_service.c
@@ -87,7 +87,6 @@ static void set_syncfile_smack_label(char *src) {
             D("fail to set label, is it transmuted?:%s\n", label);
         }
     } else {
-        free(label);
         if (smack_setlabel(src, SMACK_SYNC_FILE_LABEL, SMACK_LABEL_ACCESS) == -1) {
             D("unable to set sync file smack label %s due to %s\n", SMACK_SYNC_FILE_LABEL, strerror(errno));
         }
@@ -517,8 +516,15 @@ void file_sync_service(int fd, void *cookie)
     struct timeval timeout;
     int rv;
     int s[2];
+
+    if(sdb_socketpair(s)) {
+        D("cannot create service socket pair\n");
+        exit(-1);
+    }
     char *buffer = malloc(SYNC_DATA_MAX);
-    if(buffer == 0) goto fail;
+    if(buffer == 0) {
+        goto fail;
+    }
 
     FD_ZERO(&set); /* clear the set */
     FD_SET(fd, &set); /* add our file descriptor to the set */
@@ -526,11 +532,6 @@ void file_sync_service(int fd, void *cookie)
     timeout.tv_sec = SYNC_TIMEOUT;
     timeout.tv_usec = 0;
 
-    if(sdb_socketpair(s)) {
-        D("cannot create service socket pair\n");
-        exit(-1);
-    }
-
     pid_t pid = fork();
 
     if (pid == 0) {