From: Lucas Stach Date: Sat, 2 Oct 2021 00:59:37 +0000 (+0200) Subject: Revert "soc: imx: gpcv2: move reset assert after requesting domain power up" X-Git-Tag: v6.6.17~8918^2~15^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2b2f106eb55276a60a89ac27a52d0d738b57a546;p=platform%2Fkernel%2Flinux-rpi.git Revert "soc: imx: gpcv2: move reset assert after requesting domain power up" This reverts commit a77ebdd9f553. It turns out that the VPU domain has no different requirements, even though the downstream ATF implementation seems to suggest otherwise. Powering on the domain with the reset asserted works fine. As the changed sequence has caused sporadic issues with the GPU domains, just revert the change to go back to the working sequence. Cc: # 5.14 Signed-off-by: Lucas Stach Acked-by: Peng Fan Tested-by: Adam Ford #imx8mm-beacon Signed-off-by: Shawn Guo --- diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 39a581f..7fbf1f2 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -244,6 +244,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } + reset_control_assert(domain->reset); + if (domain->bits.pxx) { /* request the domain to power up */ regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, @@ -268,8 +270,6 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) } } - reset_control_assert(domain->reset); - /* delay for reset to propagate */ udelay(5);