From: hpayer@chromium.org Date: Tue, 4 Feb 2014 10:30:36 +0000 (+0000) Subject: Remove unused AllocationSpace paramenter from CollectGarbage. X-Git-Tag: upstream/4.7.83~10893 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2afcfc0b0e3927aec94e7a0ef151ff732e1e4bef;p=platform%2Fupstream%2Fv8.git Remove unused AllocationSpace paramenter from CollectGarbage. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/148943004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19054 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/heap-inl.h b/src/heap-inl.h index f28b82c..d42e1cf 100644 --- a/src/heap-inl.h +++ b/src/heap-inl.h @@ -555,8 +555,7 @@ bool Heap::CollectGarbage(AllocationSpace space, const v8::GCCallbackFlags callbackFlags) { const char* collector_reason = NULL; GarbageCollector collector = SelectGarbageCollector(space, &collector_reason); - return CollectGarbage( - space, collector, gc_reason, collector_reason, callbackFlags); + return CollectGarbage(collector, gc_reason, collector_reason, callbackFlags); } diff --git a/src/heap.cc b/src/heap.cc index a6db39c..4eadabe 100644 --- a/src/heap.cc +++ b/src/heap.cc @@ -739,7 +739,7 @@ void Heap::CollectAllAvailableGarbage(const char* gc_reason) { const int kMaxNumberOfAttempts = 7; const int kMinNumberOfAttempts = 2; for (int attempt = 0; attempt < kMaxNumberOfAttempts; attempt++) { - if (!CollectGarbage(OLD_POINTER_SPACE, MARK_COMPACTOR, gc_reason, NULL) && + if (!CollectGarbage(MARK_COMPACTOR, gc_reason, NULL) && attempt + 1 >= kMinNumberOfAttempts) { break; } @@ -751,8 +751,7 @@ void Heap::CollectAllAvailableGarbage(const char* gc_reason) { } -bool Heap::CollectGarbage(AllocationSpace space, - GarbageCollector collector, +bool Heap::CollectGarbage(GarbageCollector collector, const char* gc_reason, const char* collector_reason, const v8::GCCallbackFlags gc_callback_flags) { diff --git a/src/heap.h b/src/heap.h index fae2117..011ffd5 100644 --- a/src/heap.h +++ b/src/heap.h @@ -2123,7 +2123,6 @@ class Heap { // Returns whether there is a chance that another major GC could // collect more garbage. bool CollectGarbage( - AllocationSpace space, GarbageCollector collector, const char* gc_reason, const char* collector_reason,