From: Loic Poulain Date: Mon, 17 Aug 2015 14:00:21 +0000 (+0200) Subject: Bluetooth: hci_bcm: Use non-sleep version of gpio_set_value X-Git-Tag: v5.15~15163^2~37^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2af0a709134f842b67151d6b97d512184fcc4ad6;p=platform%2Fkernel%2Flinux-starfive.git Bluetooth: hci_bcm: Use non-sleep version of gpio_set_value We should not sleep while holding a spinlock. bcm_gpio_set_power is called while holding the bcm_device_list lock. Signed-off-by: Loic Poulain Signed-off-by: Marcel Holtmann --- diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c index 322302b..33ec097 100644 --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -138,8 +138,8 @@ static int bcm_gpio_set_power(struct bcm_device *dev, bool powered) if (powered && !IS_ERR(dev->clk) && !dev->clk_enabled) clk_enable(dev->clk); - gpiod_set_value_cansleep(dev->shutdown, powered); - gpiod_set_value_cansleep(dev->device_wakeup, powered); + gpiod_set_value(dev->shutdown, powered); + gpiod_set_value(dev->device_wakeup, powered); if (!powered && !IS_ERR(dev->clk) && dev->clk_enabled) clk_disable(dev->clk);