From: Jeff Layton <jlayton@kernel.org>
Date: Thu, 1 Jul 2021 14:41:46 +0000 (-0400)
Subject: ceph: fix memory leak on decode error in ceph_handle_caps
X-Git-Tag: accepted/tizen/unified/20230118.172025~6426^2~19
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2ad32cf09bd28a21e6ad1595355a023ed631b529;p=platform%2Fkernel%2Flinux-rpi.git

ceph: fix memory leak on decode error in ceph_handle_caps

If we hit a decoding error late in the frame, then we might exit the
function without putting the pool_ns string. Ensure that we always put
that reference on the way out of the function.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 39db97f..c2d6541 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -4134,8 +4134,9 @@ void ceph_handle_caps(struct ceph_mds_session *session,
 done:
 	mutex_unlock(&session->s_mutex);
 done_unlocked:
-	ceph_put_string(extra_info.pool_ns);
 	iput(inode);
+out:
+	ceph_put_string(extra_info.pool_ns);
 	return;
 
 flush_cap_releases:
@@ -4150,7 +4151,7 @@ flush_cap_releases:
 bad:
 	pr_err("ceph_handle_caps: corrupt message\n");
 	ceph_msg_dump(msg);
-	return;
+	goto out;
 }
 
 /*