From: Tim-Philipp Müller <tim@centricular.com>
Date: Wed, 6 Mar 2019 21:32:50 +0000 (+0000)
Subject: tests: fix bus leak in hls_demux testSeek unit test
X-Git-Tag: 1.16.2~202
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2ab238a4d06e8e20f739d770a8ad5973d00eff0a;p=platform%2Fupstream%2Fgst-plugins-bad.git

tests: fix bus leak in hls_demux testSeek unit test

We add the signal watch in testSeekPreTestCallback so
remove it in testSeekPostTestCallback and not deep inside
some if clause in some other callback somewhere.
---

diff --git a/tests/check/elements/adaptive_demux_common.c b/tests/check/elements/adaptive_demux_common.c
index 207ff3f..c071453 100644
--- a/tests/check/elements/adaptive_demux_common.c
+++ b/tests/check/elements/adaptive_demux_common.c
@@ -433,7 +433,6 @@ testSeekOnStateChanged (GstBus * bus, GstMessage * msg, gpointer user_data)
         TEST_TASK_STATE_WAITING_FOR_TESTSRC_STATE_CHANGE) {
       GST_DEBUG ("changing test_task_state");
       testData->test_task_state = TEST_TASK_STATE_EXITING;
-      gst_bus_remove_signal_watch (bus);
       g_cond_signal (&testData->test_task_state_cond);
     }
     g_mutex_unlock (&testData->test_task_state_lock);
@@ -464,6 +463,7 @@ static void
 testSeekPostTestCallback (GstAdaptiveDemuxTestEngine * engine,
     gpointer user_data)
 {
+  GstBus *bus;
   GList *walk;
 
   GstAdaptiveDemuxTestCase *testData = GST_ADAPTIVE_DEMUX_TEST_CASE (user_data);
@@ -472,6 +472,10 @@ testSeekPostTestCallback (GstAdaptiveDemuxTestEngine * engine,
 
     fail_if (td->segment_verification_needed);
   }
+
+  bus = gst_pipeline_get_bus (GST_PIPELINE (engine->pipeline));
+  gst_bus_remove_signal_watch (bus);
+  gst_object_unref (bus);
 }
 
 /* function to check total size of data received by AppSink