From: Yue Hu Date: Wed, 10 Mar 2021 08:27:41 +0000 (+0800) Subject: scsi: ufs: core: Remove unnecessary ret in ufshcd_populate_vreg() X-Git-Tag: v5.15~1153^2~270 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2a8561b78e377f48aa638d7cd203628b6dfc2519;p=platform%2Fkernel%2Flinux-starfive.git scsi: ufs: core: Remove unnecessary ret in ufshcd_populate_vreg() The local variable 'ret' is always zero. Remove it and return 0 at the end of the function. Link: https://lore.kernel.org/r/20210310082741.647-1-zbestahu@gmail.com Signed-off-by: Yue Hu Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 1a69949..fedb7de 100644 --- a/drivers/scsi/ufs/ufshcd-pltfrm.c +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c @@ -106,7 +106,6 @@ out: static int ufshcd_populate_vreg(struct device *dev, const char *name, struct ufs_vreg **out_vreg) { - int ret = 0; char prop_name[MAX_PROP_SIZE]; struct ufs_vreg *vreg = NULL; struct device_node *np = dev->of_node; @@ -135,9 +134,8 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, vreg->max_uA = 0; } out: - if (!ret) - *out_vreg = vreg; - return ret; + *out_vreg = vreg; + return 0; } /**