From: Hoyeonjiki Kim <jigi.kim@gmail.com>
Date: Tue, 17 Nov 2020 03:32:08 +0000 (+0900)
Subject: env: mmc: Correct partition comparison in mmc_offset_try_partition
X-Git-Tag: v2021.10~426^2~38
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2a0a577aad4337eab24812911df248a9a8c4ebd0;p=platform%2Fkernel%2Fu-boot.git

env: mmc: Correct partition comparison in mmc_offset_try_partition

The function mmc_offset_try_partition searches the MMC partition for
locating environment data, by comparing the partition names with config
"u-boot,mmc-env-parition". However, it only compares the first word-size
bytes (size of 'const char *'), which may make the function to find
unintended partition.

Correct the function not to partially compare the partition name with
config "u-boot,mmc-env-partition".

Fixes: c9e87ba66540 ("env: Save environment at the end of an MMC partition")
Signed-off-by: Hoyeonjiki Kim <jigi.kim@gmail.com>
Reviewed-by: Wolfgang Denk <wd@denx.de>
---

diff --git a/env/mmc.c b/env/mmc.c
index 4e67180..ee376c3 100644
--- a/env/mmc.c
+++ b/env/mmc.c
@@ -42,7 +42,7 @@ static inline int mmc_offset_try_partition(const char *str, int copy, s64 *val)
 		if (ret < 0)
 			return ret;
 
-		if (!strncmp((const char *)info.name, str, sizeof(str)))
+		if (!strncmp((const char *)info.name, str, sizeof(info.name)))
 			break;
 	}