From: Andy Shevchenko Date: Fri, 18 Aug 2023 13:36:54 +0000 (+0300) Subject: driver core: Call in reversed order in device_platform_notify_remove() X-Git-Tag: v6.6.7~2017^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=29c8ab79e91d35b93cfab87bf67a11516f7b2051;p=platform%2Fkernel%2Flinux-starfive.git driver core: Call in reversed order in device_platform_notify_remove() It's logically correct to call the removal notifiers in the reversed order as it might be dependent to each other. Luckily, platform_notify_remove() currently is not used and the others have no dependency use, but theoretically it's still possible. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20230818133654.767986-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/base/core.c b/drivers/base/core.c index eb3a93d..39f7a94 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2306,12 +2306,12 @@ static void device_platform_notify(struct device *dev) static void device_platform_notify_remove(struct device *dev) { - acpi_device_notify_remove(dev); + if (platform_notify_remove) + platform_notify_remove(dev); software_node_notify_remove(dev); - if (platform_notify_remove) - platform_notify_remove(dev); + acpi_device_notify_remove(dev); } /**