From: hablich Date: Fri, 19 Jun 2015 09:32:37 +0000 (-0700) Subject: Revert of [release-tools] Fix possible race condition in retrieval of latest rolled... X-Git-Tag: upstream/4.7.83~1900 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=29c575bc7e8b896d566599419e6f73ec349b30fe;p=platform%2Fupstream%2Fv8.git Revert of [release-tools] Fix possible race condition in retrieval of latest rolled version (patchset #2 id:20001 of https://codereview.chromium.org/1186393007/) Reason for revert: Build slave fetches git repo from cache not from real repo. Original issue's description: > [release-tools] Fix possible race condition in retrieval of latest rolled version > > R=machenbach@chromium.org > BUG= > NOTRY=true > > Committed: https://crrev.com/5d2a85b2450f9f88a94949052c5b055c1304b9b8 > Cr-Commit-Position: refs/heads/master@{#29137} TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1195693003 Cr-Commit-Position: refs/heads/master@{#29140} --- diff --git a/tools/release/auto_roll.py b/tools/release/auto_roll.py index ed2ab21..f7692cf 100755 --- a/tools/release/auto_roll.py +++ b/tools/release/auto_roll.py @@ -48,9 +48,6 @@ class DetectLastRoll(Step): max_age=self._options.max_age * DAY_IN_SECONDS) assert revisions, "Didn't find any recent release." - # Update Chromium checkout before DEPS check to fix possible race-condition - self.GitPull(cwd=self._options.chromium) - # Interpret the DEPS file to retrieve the v8 revision. # TODO(machenbach): This should be part or the roll-deps api of # depot_tools. diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py index da4f2d1..32d0fb8 100644 --- a/tools/release/test_scripts.py +++ b/tools/release/test_scripts.py @@ -1112,7 +1112,6 @@ deps = { Cmd("git describe --tags bad_tag", ""), Cmd("git describe --tags hash_234", "3.22.4"), Cmd("git describe --tags hash_123", "3.22.3"), - Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]), Cmd("git describe --tags abcd123455", "3.22.4"), Cmd("git describe --tags hash_234", "3.22.4"), Cmd("git describe --tags hash_123", "3.22.3"), @@ -1136,7 +1135,6 @@ deps = { Cmd("git describe --tags bad_tag", ""), Cmd("git describe --tags hash_234", "3.22.4"), Cmd("git describe --tags hash_123", "3.22.3"), - Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]), Cmd("git describe --tags abcd123455", "3.22.3.1"), Cmd("git describe --tags hash_234", "3.22.4"), ])