From: Karl Williamson <public@khwilliamson.com>
Date: Mon, 7 Oct 2013 04:14:45 +0000 (-0600)
Subject: Remove PerlIO_sprintf() and PerlIO_vsprintf()
X-Git-Tag: upstream/5.20.0~1593
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=29b43da2723775cbc8877ecd48c8e5aae8f087bc;p=platform%2Fupstream%2Fperl.git

Remove PerlIO_sprintf() and PerlIO_vsprintf()

http://markmail.org/message/m6bvkxvqnvjnfgyf
---

diff --git a/perlio.c b/perlio.c
index 2591f89..279b529 100644
--- a/perlio.c
+++ b/perlio.c
@@ -5183,36 +5183,6 @@ vfprintf(FILE *fd, char *pat, char *args)
 
 #endif
 
-#ifndef PerlIO_vsprintf
-int
-PerlIO_vsprintf(char *s, int n, const char *fmt, va_list ap)
-{
-    dTHX; 
-    const int val = my_vsnprintf(s, n > 0 ? n : 0, fmt, ap);
-    PERL_UNUSED_CONTEXT;
-
-#ifndef PERL_MY_VSNPRINTF_GUARDED
-    if (val < 0 || (n > 0 ? val >= n : 0)) {
-	Perl_croak(aTHX_ "panic: my_vsnprintf overflow in PerlIO_vsprintf\n");
-    }
-#endif
-    return val;
-}
-#endif
-
-#ifndef PerlIO_sprintf
-int
-PerlIO_sprintf(char *s, int n, const char *fmt, ...)
-{
-    va_list ap;
-    int result;
-    va_start(ap, fmt);
-    result = PerlIO_vsprintf(s, n, fmt, ap);
-    va_end(ap);
-    return result;
-}
-#endif
-
 /*
  * Local variables:
  * c-indentation-style: bsd
diff --git a/pod/perldelta.pod b/pod/perldelta.pod
index 1da12d8..9c8531b 100644
--- a/pod/perldelta.pod
+++ b/pod/perldelta.pod
@@ -78,6 +78,11 @@ XXX For a release on a stable branch, this section aspires to be:
 
 [ List each incompatible change as a =head2 entry ]
 
+=head2 Functions C<PerlIO_vsprintf> and C<PerlIO_sprintf> have been removed
+
+These two functions, undocumented, unused in CPAN, and problematic have
+been removed.
+
 =head1 Deprecations
 
 XXX Any deprecated features, syntax, modules etc. should be listed here.