From: Christophe Leroy Date: Thu, 6 Oct 2022 05:33:17 +0000 (+0200) Subject: fbdev: mb862xx: Fix check of return value from irq_of_parse_and_map() X-Git-Tag: v6.1-rc5~204^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=29926f1cd3535f565f200430d5b6a794543fe130;p=platform%2Fkernel%2Flinux-starfive.git fbdev: mb862xx: Fix check of return value from irq_of_parse_and_map() NO_IRQ is used to check the return of irq_of_parse_and_map(). On some architecture NO_IRQ is 0, on other architectures it is -1. irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ. So use 0 instead of using NO_IRQ. Signed-off-by: Christophe Leroy Signed-off-by: Helge Deller --- diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c index 96800c9..90c79e8 100644 --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c @@ -693,7 +693,7 @@ static int of_platform_mb862xx_probe(struct platform_device *ofdev) par->dev = dev; par->irq = irq_of_parse_and_map(np, 0); - if (par->irq == NO_IRQ) { + if (!par->irq) { dev_err(dev, "failed to map irq\n"); ret = -ENODEV; goto fbrel;