From: Wei Yongjun Date: Thu, 11 Jan 2018 11:21:51 +0000 (+0000) Subject: net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe() X-Git-Tag: v4.19~1702^2~178 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=297a6961ffb8ff4dc66c9fbf53b924bd1dda05d5;p=platform%2Fkernel%2Flinux-rpi.git net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe() platform_get_resource() may fail and return NULL, so we should better check it's return value to avoid a NULL pointer dereference a bit later in the code. This is detected by Coccinelle semantic patch. @@ expression pdev, res, n, t, e, e1, e2; @@ res = platform_get_resource(pdev, t, n); + if (!res) + return -EINVAL; ... when != res == NULL e = devm_ioremap(e1, res->start, e2); Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/mdio-bcm-unimac.c b/drivers/net/phy/mdio-bcm-unimac.c index 08e0647..8d37066 100644 --- a/drivers/net/phy/mdio-bcm-unimac.c +++ b/drivers/net/phy/mdio-bcm-unimac.c @@ -205,6 +205,8 @@ static int unimac_mdio_probe(struct platform_device *pdev) return -ENOMEM; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!r) + return -EINVAL; /* Just ioremap, as this MDIO block is usually integrated into an * Ethernet MAC controller register range