From: Christoph Hellwig Date: Thu, 8 Jun 2023 11:02:40 +0000 (+0200) Subject: bcache: don't pass a stack address to blkdev_get_by_path X-Git-Tag: v6.6.7~2487^2~67 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=29499ab060fec044161be73fb0e448eab97b4813;p=platform%2Fkernel%2Flinux-starfive.git bcache: don't pass a stack address to blkdev_get_by_path sb is just an on-stack pointer that can easily be reused by other calls. Switch to use the bcache-wide bcache_kobj instead as there is no need to claim per-bcache device anyway. Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20230608110258.189493-13-hch@lst.de Signed-off-by: Jens Axboe --- diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 94b91c4..4a2aed0 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -2560,7 +2560,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, err = "failed to open device"; bdev = blkdev_get_by_path(strim(path), FMODE_READ|FMODE_WRITE|FMODE_EXCL, - sb, NULL); + bcache_kobj, NULL); if (IS_ERR(bdev)) { if (bdev == ERR_PTR(-EBUSY)) { dev_t dev;