From: Dan Carpenter Date: Wed, 1 Feb 2012 07:43:31 +0000 (+0300) Subject: ath9k: cleanup a min_t() cast X-Git-Tag: v3.12-rc1~3664^2~112^2~323 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=291689fcfbf0046d17c83c36fc983400f499dec3;p=kernel%2Fkernel-generic.git ath9k: cleanup a min_t() cast If the firmware was over 2G, it would cause memory corruption and the system would die here. Obviously we all know the firmware isn't going to be that large but static checkers get upset. Signed-off-by: Dan Carpenter Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c index f317515..424aabb 100644 --- a/drivers/net/wireless/ath/ath9k/hif_usb.c +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c @@ -981,7 +981,7 @@ static int ath9k_hif_usb_download_fw(struct hif_device_usb *hif_dev) return -ENOMEM; while (len) { - transfer = min_t(int, len, 4096); + transfer = min_t(size_t, len, 4096); memcpy(buf, data, transfer); err = usb_control_msg(hif_dev->udev,